Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Yurtappdaemon e2e test #1406

Merged
merged 9 commits into from
Apr 23, 2023
Merged

Conversation

theonefx
Copy link
Contributor

What type of PR is this?

/kind feature

add Yurtappdaemon e2e test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1396

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Signed-off-by: theonefx <chenxilzx1@gmail.com>
Signed-off-by: theonefx <chenxilzx1@gmail.com>
Signed-off-by: theonefx <chenxilzx1@gmail.com>
Signed-off-by: theonefx <chenxilzx1@gmail.com>
Signed-off-by: theonefx <chenxilzx1@gmail.com>
@openyurt-bot
Copy link
Collaborator

@theonefx: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

add Yurtappdaemon e2e test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1396

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/feature kind/feature size/L size/L: 100-499 labels Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #1406 (d986b88) into master (c08779f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1406   +/-   ##
=======================================
  Coverage   51.05%   51.05%           
=======================================
  Files         132      132           
  Lines       15568    15568           
=======================================
  Hits         7949     7949           
  Misses       6895     6895           
  Partials      724      724           
Flag Coverage Δ
unittests 51.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@theonefx how about add a test case that workloads will be removed automatically when nodepool is removed?

Signed-off-by: theonefx <chenxilzx1@gmail.com>
Signed-off-by: theonefx <chenxilzx1@gmail.com>
Signed-off-by: theonefx <chenxilzx1@gmail.com>
@theonefx
Copy link
Contributor Author

@theonefx how about add a test case that workloads will be removed automatically when nodepool is removed?

done

@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, theonefx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Apr 23, 2023
@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]add e2e test case for YurtAppDeamon controller
3 participants